gh-146376: Reduce timeout in Emscripten workflow#146378
Open
hoodmane wants to merge 1 commit intopython:mainfrom
Open
gh-146376: Reduce timeout in Emscripten workflow#146378hoodmane wants to merge 1 commit intopython:mainfrom
hoodmane wants to merge 1 commit intopython:mainfrom
Conversation
hoodmane
requested review from
AA-Turner,
ezio-melotti,
hugovk and
webknjaz
as code owners
Member
|
Does Emscripten supports |
Member
|
@vstinner if that's possible, I'd recommend both timeouts (with different values). Also, this sounds like something to do in other jobs too. |
hugovk
reviewed
Mar 29, 2026
Comment on lines
+13
to
+26
| # It seems to take about 20 minutes without the cache, broken down as follows: | ||
| # (All times recorded from one run chosen arbitrarily.) | ||
| # | ||
| # 0.5 install Emscripten (skipped by cache) | ||
| # 1.0 configure & build native python | ||
| # 0.5 build dependencies (skipped by cache) | ||
| # 3.0 configure Emscripten Python | ||
| # 1.5 build Emscripten Python | ||
| # 0.7 build Emscripten ports (skipped by cache) | ||
| # 14.0 Test | ||
| # | ||
| # So if we add time for a rerun of the entire test suite, we get to 34 | ||
| # minutes. Adding an extra 5% gets us to 36. | ||
| timeout-minutes: 36 |
Member
There was a problem hiding this comment.
I don't think we need all the calculations here. It can be in the PR description.
And let's round the number. If the time starts being too short, we'll just bump it up a bit.
Suggested change
| # It seems to take about 20 minutes without the cache, broken down as follows: | |
| # (All times recorded from one run chosen arbitrarily.) | |
| # | |
| # 0.5 install Emscripten (skipped by cache) | |
| # 1.0 configure & build native python | |
| # 0.5 build dependencies (skipped by cache) | |
| # 3.0 configure Emscripten Python | |
| # 1.5 build Emscripten Python | |
| # 0.7 build Emscripten ports (skipped by cache) | |
| # 14.0 Test | |
| # | |
| # So if we add time for a rerun of the entire test suite, we get to 34 | |
| # minutes. Adding an extra 5% gets us to 36. | |
| timeout-minutes: 36 | |
| timeout-minutes: 40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.